Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supermicro/x12: support BIOS firmware updates on X12SPO-NTF #389

Merged
merged 1 commit into from
May 2, 2024

Conversation

joelrebel
Copy link
Member

What does this PR implement/change/remove?

Support BIOS firmware updates on X12SPO-NTF

verified changes work with both BIOS and BMC updates on the hardware.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

SMC

The HW model number, product name this change applies to (if applicable)

X12SPO-NTF

@joelrebel joelrebel requested review from DoctorVin and splaspood May 2, 2024 09:47
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 37.48%. Comparing base (8dc2d91) to head (a6ac6b6).
Report is 27 commits behind head on main.

Files Patch % Lines
providers/supermicro/x12.go 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
- Coverage   43.83%   37.48%   -6.35%     
==========================================
  Files          61       78      +17     
  Lines        5368     6405    +1037     
==========================================
+ Hits         2353     2401      +48     
- Misses       2795     3782     +987     
- Partials      220      222       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs a golang-cilint update?

@joelrebel
Copy link
Member Author

GTM but needs a golang-cilint update?

True, will take that up in another PR

@joelrebel joelrebel merged commit 877feee into main May 2, 2024
5 of 7 checks passed
@joelrebel joelrebel deleted the x12-spo-bios branch May 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants