Update firmware install status for scheduling state #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 43.47% 43.47%
=======================================
Files 59 59
Lines 5274 5274
=======================================
Hits 2293 2293
Misses 2762 2762
Partials 219 219 ☔ View full report in Codecov by Sentry. |
|
good catch, |
I see you're moving the firmware file in that branch. Looks like your PR has the approvals. I can wait for that to merge first before merging this one. |
coffeefreak101
force-pushed
the
switch-state-scheduling-fix
branch
from
9d412eb to
1e2d807
Compare
|
I rebased and fixed this base on the new code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
During my firmware update testing, I encountered a situation where the firmware update status went from "initializing" to "running" for just a second, then to "powercycle-host" then back to "running".
This occurred because the BMC's "scheduling" state gets reported as "running", and the "scheduled" state is reported as "powercycle-host".
This change moves "scheduling" BMC state to the "initializing" firmware update status.