Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/4] Move methods under the redfishwrapper for reuse #369

Merged
merged 27 commits into from
Nov 29, 2023

Merge pull request #370 from bmc-toolbox/smc-redfish-fixes

ee0f228
Select commit
Loading
Failed to load commit list.
Merged

[1/4] Move methods under the redfishwrapper for reuse #369

Merge pull request #370 from bmc-toolbox/smc-redfish-fixes
ee0f228
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 29, 2023 in 0s

43.87% (-0.74%) compared to b565dd4

View this Pull Request on Codecov

43.87% (-0.74%) compared to b565dd4

Details

Codecov Report

Attention: 226 lines in your changes are missing coverage. Please review.

Comparison is base (b565dd4) 44.60% compared to head (ee0f228) 43.87%.

Files Patch % Lines
providers/dell/firmware.go 9.34% 96 Missing and 1 partial ⚠️
internal/redfishwrapper/inventory.go 11.76% 45 Missing ⚠️
internal/redfishwrapper/inventory_collect.go 10.34% 26 Missing ⚠️
providers/supermicro/supermicro.go 30.43% 14 Missing and 2 partials ⚠️
internal/redfishwrapper/power.go 0.00% 14 Missing ⚠️
client.go 0.00% 7 Missing ⚠️
internal/redfishwrapper/task.go 76.19% 3 Missing and 2 partials ⚠️
providers/redfish/redfish.go 0.00% 5 Missing ⚠️
providers/dell/idrac.go 69.23% 4 Missing ⚠️
internal/redfishwrapper/system.go 40.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@                       Coverage Diff                       @@
##           devel-rework-redfishwrapper     #369      +/-   ##
===============================================================
- Coverage                        44.60%   43.87%   -0.74%     
===============================================================
  Files                               61       59       -2     
  Lines                             5206     5042     -164     
===============================================================
- Hits                              2322     2212     -110     
+ Misses                            2628     2608      -20     
+ Partials                           256      222      -34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov