Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Asrockrack e3C256D4ID-NL #366

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Support for Asrockrack e3C256D4ID-NL #366

merged 2 commits into from
Nov 24, 2023

Conversation

ofaurax
Copy link
Collaborator

@ofaurax ofaurax commented Nov 16, 2023

Asrockrack e3C256D4ID-NL

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (834c495) 44.60% compared to head (ac79419) 44.60%.

❗ Current head ac79419 differs from pull request most recent head b031bea. Consider uploading reports for the commit b031bea to get more accurate results

Files Patch % Lines
providers/asrockrack/firmware.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   44.60%   44.60%   -0.01%     
==========================================
  Files          61       61              
  Lines        5201     5206       +5     
==========================================
+ Hits         2320     2322       +2     
- Misses       2625     2628       +3     
  Partials      256      256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ofaurax ofaurax force-pushed the ofdev branch 2 times, most recently from 07f29ef to d4de074 Compare November 17, 2023 07:31
@ofaurax ofaurax changed the title Support for m3.small.x86 Support for Asrockrack e3C256D4ID-NL Nov 17, 2023
@ofaurax ofaurax marked this pull request as ready for review November 21, 2023 15:22
@ofaurax ofaurax force-pushed the ofdev branch 2 times, most recently from fdc81bb to ac79419 Compare November 23, 2023 17:41
@ofaurax ofaurax requested a review from joelrebel November 23, 2023 17:41
@ofaurax ofaurax enabled auto-merge (rebase) November 23, 2023 17:42
joelrebel
joelrebel reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - suggested a minor change

@ofaurax ofaurax requested a review from joelrebel November 24, 2023 11:04
@ofaurax ofaurax merged commit b565dd4 into main Nov 24, 2023
5 checks passed
@ofaurax ofaurax deleted the ofdev branch November 24, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelrebel joelrebel joelrebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofaurax @joelrebel