Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Odata ID for MegaRAC/AsRockRack Systems & Managers #358

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

ofaurax
Copy link
Collaborator

@ofaurax ofaurax commented Nov 3, 2023

What does this PR implement/change/remove?

Add Odata ID for Systems & Managers (Chassis was already there)

The HW vendor this change applies to (if applicable)

AsRockRack

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81949eb) 44.50% compared to head (9246a6a) 44.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   44.50%   44.50%           
=======================================
  Files          56       56           
  Lines        4417     4417           
=======================================
  Hits         1966     1966           
  Misses       2234     2234           
  Partials      217      217           
Files Coverage Δ
providers/redfish/inventory.go 5.46% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ofaurax ofaurax force-pushed the fs-989-add-odata-asrockrack branch from 2c7e286 to 9246a6a Compare November 3, 2023 15:13
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes 👍
Going ahead we'll remove the System, Chassis Odata check since its getting prohibitive to support newer hardware.

@ofaurax ofaurax merged commit 643a35b into main Nov 3, 2023
7 checks passed
@ofaurax ofaurax deleted the fs-989-add-odata-asrockrack branch November 3, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants