-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
providers/redfish/tasks: returns TaskNotFound on 404 #352
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 44.53% 44.65% +0.12%
==========================================
Files 51 51
Lines 4116 4116
==========================================
+ Hits 1833 1838 +5
+ Misses 2073 2069 -4
+ Partials 210 209 -1
☔ View full report in Codecov by Sentry. |
b0d7f45
to
ce8aca3
Compare
ce8aca3
to
ffe4861
Compare
8416822
to
4f017f8
Compare
@ofaurax can you also include a few more fixes - I missed this in the previous PR,
bmclib/providers/redfish/tasks.go Line 50 in 1f97b35
bmclib/providers/redfish/tasks.go Line 152 in 1f97b35
err = json.Unmarshal(data, &status)
if err != nil {
return nil, err
}
task = &gofishrf.Task{
TaskState: gofishrf.TaskState(status.TaskState),
TaskStatus: gofishcommon.Health(status.TaskStatus),
}
return task, err |
7e85d8f
to
13a2260
Compare
13a2260
to
e478fd0
Compare
What does this PR implement/change/remove?
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes