Adds BmcReset methods and few fixes for ASRR firmware installed version checks #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… FirmwareInstallUnknown this is so that the caller is aware that the BMC is not aware of the component version and can decide if it wants to power cycle or take other actions. instead of assuming the device needs a powercycle
…payload this is an attempt to have the BMC preserve the User, Network BMC configuration after a flash
…eset error returned when the install status lookup fails
This enables the ASRR and Redfish providers to reset the BMC
- moves the optional component parameter at the end - providers/asrockrack/firmware: wrap FirmwareInstall errors
joelrebel
force-pushed
the
inventory-firmware-1
branch
from
4699548 to
7503c32
Compare
joelrebel
force-pushed
the
inventory-firmware-1
branch
from
7503c32 to
da0793a
Compare
micahhausler
suggested changes
Apr 25, 2022
| @@ -40,23 +39,17 @@ func main() { | |||
|
|
|||
| defer cl.Close(ctx) | |||
|
|
|||
| for _, update := range []string{"/tmp/iDRAC-with-Lifecycle-Controller_Firmware_F87RP_WN64_5.00.00.00_A00.EXE"} { | |||
| for _, update := range []string{"/tmp/E6D4INL2.09C.ima"} { | |||
There was a problem hiding this comment.
want to make this a flag-provided value?
micahhausler
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
InventoryGetterimplementation - method renamedBmcResetterinterface for ASRR, RedfishFirmwareInstallUnknown, when the BMC returns an empty version stringThe HW vendor this change applies to
Description for changelog/release notes
BmcResetterinterface for ASRR, Redfish