Add TODO for streaming the update data

bmc-toolbox · Sep 5, 2023 · bc153ee · bc153ee
1 parent 92258c6
commit bc153ee
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/providers/redfish/firmware.go b/providers/redfish/firmware.go
@@ -173,9 +173,10 @@ func (c *Conn) unstructuredHttpUpload(ctx context.Context, url, applyAt string,
 		return nil, fmt.Errorf("unable to execute request, no target provided")
 	}
 
+	// TODO: transform this to read the update so that we don't hold the data in memory
 	b, _ := io.ReadAll(update)
-
 	payloadReadSeeker := bytes.NewReader(b)
+
 	return c.redfishwrapper.RunRawRequestWithHeaders(http.MethodPost, url, payloadReadSeeker, "application/octet-stream", nil)
 
 }