Fix media mounting:

Some redfish implementations will fail to eject media if no media is mounted. The redfish server behavior is to report that the virtual media doesn't support media ejection. So we need to check for this. Signed-off-by: Jacob Weinstock <[email protected]>
bmc-toolbox · Nov 24, 2024 · a19c4c2 · a19c4c2
1 parent 31918a0
commit a19c4c2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/redfishwrapper/virtual_media.go b/internal/redfishwrapper/virtual_media.go
@@ -44,7 +44,7 @@ func (c *Client) SetVirtualMedia(ctx context.Context, kind string, mediaURL stri
 
 		for _, vm := range virtualMedia {
 			var ejected bool
-			if vm.Inserted {
+			if vm.Inserted && vm.SupportsMediaEject {
 				if err := vm.EjectMedia(); err != nil {
 					return false, err
 				}
@@ -53,7 +53,7 @@ func (c *Client) SetVirtualMedia(ctx context.Context, kind string, mediaURL stri
 			if mediaURL == "" {
 				// Only ejecting the media was requested.
 				// For BMC's that don't support the "inserted" property, we need to eject the media if it's not already ejected.
-				if !ejected {
+				if !ejected && vm.SupportsMediaEject {
 					if err := vm.EjectMedia(); err != nil {
 						return false, err
 					}