Skip to content

Commit

Permalink
Retry on top
Browse files Browse the repository at this point in the history
  • Loading branch information
ofaurax committed Nov 10, 2023
1 parent be814d3 commit 1c1f49d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion providers/asrockrack/firmware.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ func (a *ASRockRack) FirmwareInstallStatus(ctx context.Context, installVersion,
func (a *ASRockRack) firmwareInstallBMC(ctx context.Context, reader io.Reader, fileSize int64) error {
var err error

mybytes, err := io.ReadAll(reader)

Check failure on line 71 in providers/asrockrack/firmware.go

View workflow job for this annotation

GitHub Actions / lint

ineffectual assignment to err (ineffassign)
fmt.Printf("ReadAll reader before FRU len:%d\n", len(mybytes))

// 0. take the model so that we use a different endpoint on E3C256D4ID-NL
device := common.NewDevice()
device.Metadata = map[string]string{}
Expand All @@ -76,7 +79,7 @@ func (a *ASRockRack) firmwareInstallBMC(ctx context.Context, reader io.Reader, f
return errors.Wrap(err, "failed to get model in step 0/4")
}

mybytes, err := io.ReadAll(reader)
mybytes, err = io.ReadAll(reader)

Check failure on line 82 in providers/asrockrack/firmware.go

View workflow job for this annotation

GitHub Actions / lint

ineffectual assignment to err (ineffassign)
fmt.Printf("ReadAll reader afterFRU len:%d\n", len(mybytes))

// 1. set the device to flash mode - prepares the flash
Expand Down

0 comments on commit 1c1f49d

Please sign in to comment.