Tut28 - 29 preliminary code #37
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we use an implementation of the transitionImageLayout function that is more flexible and supports more image layouts instead of hardcoding every specific situation like it is now? Maybe something along the lines of this? Link |
ghost
reviewed
Dec 16, 2023
|
|
||
| id_t id; | ||
| const LveGameObjectManager &gameObjectManger; |
bobis33
reviewed
Oct 17, 2024
|
|
||
| void LveTexture::createTextureImage(const std::string &filepath) { | ||
| int texWidth, texHeight, texChannels; | ||
| // stbi_set_flip_vertically_on_load(1); // todo determine why texture coordinates are flipped |
There was a problem hiding this comment.
use
stbi_set_flip_vertically_on_load(1);:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough draft of code for tutorials 28 and 29 covering per frame descriptors, game object manager and textures