Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

add mpdf lib - add php 7.2 support - add TYPO3 9.5 support - code format #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Teisi
Copy link

@Teisi Teisi commented Oct 17, 2019

Add mpdf to this repo to change this mpdf 6.1 version for support of php 7.2.

@schnere
Copy link
Contributor

schnere commented Oct 19, 2019

Thanks for your contribution! Unfortunately I don't want to have a copy of mpdf in this repository.
Please remove your .editorconfig and the mpdf lib and I'll take a look.

@Teisi
Copy link
Author

Teisi commented Oct 19, 2019

No problem, but why you don't want a "editorconfig" file in it?
https://editorconfig.org/

Mpdf:
And the problem is that this version of mpdf is not compatible with PHP 7.2 example:
the original code at mpdf.php: "while (list($file, $info) = each($this->formobjects)) {" have to be now a foreach...
If you don't want the (modified) lib in this repo than we have to use the current mpdf version.
I think that would require much more (re-)programming.
I understand that you don't like the hole mpdf lib in your repo (not the best solution), but it is the simplest solution :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants