Support for Google API Client V2 #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for Google API Client V2 is added when using composer to install bluevisiontec/googleshoppingapi package. Backward compatibility is maintained users with previous Google API Client versions. When using V2 you must use the JSON key file instead of the old P12. Also added is a configuration switch to hide the client_id, client_secret and client_email options because they can be inferred from the JSON key file.
Google API client V2 no longer has the Google_Utils class. The code was taken from the camelCase implementation on the previous version and added as an anonymous function.
This was referenced Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds support for Google API Client V2 is added when using composer to install bluevisiontec/googleshoppingapi package. Backward compatibility is maintained users with previous Google API Client versions.
When using V2 you must use the JSON key file instead of the old P12 format so make sure to update the private key file in the configuration. Also added is a configuration switch to hide the
client_id,client_secretandclient_emailoptions because they can be inferred from the JSON key file. The goal for the future is have this done automatically (don't know how yet).At the moment this PR is just a call for additional testers to confirm that it works under their current setup to avoid breaking current installs.
Best regards,
Ricardo Velhote