Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hint to PandA if we can't find a block #668

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Add a hint to PandA if we can't find a block #668

merged 2 commits into from
Nov 27, 2024

Conversation

coretl
Copy link
Collaborator

@coretl coretl commented Nov 22, 2024

Fixes #574

@coretl coretl requested a review from DominicOram November 22, 2024 16:51
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, one suggestion. @olliesilvester, could you add some docs somewhere on our side of how to actually test what panda IOC you're running and how to update it if required?

src/ophyd_async/fastcs/panda/_hdf_panda.py Outdated Show resolved Hide resolved
@coretl coretl requested a review from DominicOram November 26, 2024 15:20
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@coretl coretl merged commit 077245a into main Nov 27, 2024
20 checks passed
@coretl coretl deleted the panda-hint branch November 27, 2024 11:01
evalott100 pushed a commit that referenced this pull request Nov 27, 2024
* Add a hint to PandA if we can't find a block

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output custom error message when fill_pvi_entries fails on PAndA
2 participants