Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move panda save load into plan stubs #352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evalott100
Copy link
Contributor

@evalott100 evalott100 commented May 31, 2024

The device save load is the only run-engine dependent thing outside of plan stubs. We should move it.

@evalott100 evalott100 self-assigned this May 31, 2024
@evalott100 evalott100 marked this pull request as draft May 31, 2024 10:23
@evalott100 evalott100 changed the title moved save and load to plan stubs Modify Panda dataset names May 31, 2024
@evalott100 evalott100 force-pushed the 330-panda-dataset-naming branch from 060b3d4 to c3635f7 Compare June 3, 2024 08:54
@evalott100 evalott100 changed the title Modify Panda dataset names Move panda save load into plan stubs Jun 18, 2024
@evalott100 evalott100 force-pushed the 330-panda-dataset-naming branch from c3635f7 to f8aca8c Compare June 18, 2024 09:41
@evalott100 evalott100 marked this pull request as ready for review June 18, 2024 09:42
@evalott100 evalott100 requested a review from abbiemery June 18, 2024 09:42
@evalott100 evalott100 force-pushed the 330-panda-dataset-naming branch from f8aca8c to 0124ea4 Compare June 18, 2024 09:43
@evalott100 evalott100 requested a review from coretl June 18, 2024 10:03
@coretl
Copy link
Collaborator

coretl commented Jun 18, 2024

Please can we do this as part of the big refactor #383 rather than in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants