Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDS_MANUAL_CERTS env set #3091

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesmanes
Copy link

@jamesmanes jamesmanes commented Nov 23, 2024

NOTE: Second PR on the PDS side to leverage this can be found here: bluesky-social/pds#155

Rationale

PDS administrators may want to leverage caddy for on-demand TLS rather than hack around with nginx or another server.

Approach

With the introduction of a PDS_MANUAL_CERTS env property, PDS administrators can add a comma-separated list of subdomains (e.g., j.manes.xyz, portfolio.manes.xyz, work.manes.xyz).

Example

I own https://manes.xyz. My handle is james.manes.xyz. I used this domain in the past for a personal landing page at https://j.manes.xyz. I want a cert to exist for j.manes.xyz so that I can properly redirect it or proxy-pass it in the caddy config file without having to replace caddy with nginx or apache.

@ledlamp
Copy link

ledlamp commented Nov 28, 2024

What? This makes no sense. Just add your sites to the caddy config and it will get certs.

@jamesmanes
Copy link
Author

What? This makes no sense. Just add your sites to the caddy config and it will get certs.

Can you offer an example? Adding sites to the caddy config was not enough for me, as there is a check in the index.js file that excludes subdomains that do not have PDS accounts associated with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants