Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove devDep '@atproto/bsky' from pds #3010

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove devDep '@atproto/bsky' from pds #3010

wants to merge 2 commits into from
+0 −4

Conversation

trivikr
Copy link

@trivikr trivikr commented Nov 15, 2024

Fixes: #3009

Before

$ make deps 
pnpm install --frozen-lockfile
Scope: all 43 workspace projects
 WARN  There are cyclic workspace dependencies: /Users/trivikram/workspace/atproto/packages/bsky, /Users/trivikram/workspace/atproto/packages/pds
Lockfile is up to date, resolution step is skipped
...

After

$ make deps
pnpm install --frozen-lockfile
Scope: all 43 workspace projects
Lockfile is up to date, resolution step is skipped
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix or disable pnpm warning "There are cyclic workspace dependencies"
1 participant
@trivikr