Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed length check for hashtags #2657

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed length check for hashtags #2657

wants to merge 1 commit into from
+2 −1

Conversation

nnabeyang
Copy link
Contributor

This PR fixes length check for hastags.

@nnabeyang
Copy link
Contributor Author

@estrattonbailey
I’m following up on PR #2242, where I’ve modified the hashtag length check to use graphemeLen instead of UTF-16 code points. I understand that this change may introduce additional computational cost due to counting graphemes.

According to the change history, it looks like you reviewed the original code changes, so I’d appreciate it if you could review this PR as well.

@nnabeyang
Fix hashtag length check to use graphemeLen for accurate length detec…
e44733d 
…tion based on grapheme units instead of UTF-16 code points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vincentroland Vincentroland Vincentroland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnabeyang @Vincentroland