fix: blockHeight, absoluteSlot and blockTime should actually be withi… #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiwinnetou
commented
Feb 7, 2024
| transactionContent.setBlockHeight(txInfo.getBlockHeight()); | ||
| transactionContent.setBlockTime(txInfo.getTxTimestamp()); | ||
| transactionContent.setSlot(txInfo.getAbsoluteSlot()); | ||
| if (txInfo.getBlockHeight() != null) { |
There was a problem hiding this comment.
Can we make assumption that any of these value will never be null? I find my own defensive programming here a bit clunky.
There was a problem hiding this comment.
@matiwinnetou Thanks for the PR.
These should not be null unless there is a defect on the provider's side. But I think we can keep this null check.
There was a problem hiding this comment.
ok, feel free to merge when you think this is fine and right time for it.
satran004
approved these changes
Feb 8, 2024
edridudi
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Will Change data types in Koios Java Client as well for the next version:
cardano-community/koios-java-client#161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n type: long