Skip to content
This repository has been archived by the owner on Jun 13, 2019. It is now read-only.

Update to add an instance_id attribute. #26

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Update to add an instance_id attribute. #26

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7def855
Update to add an instance_id attribute.
saheemg Nov 21, 2016
684bda4
Added instance_id.
saheemg Nov 21, 2016
0a60fc1
Merge pull request #1 from InfrastructureEngineering/addInstanceId
yogeswaran Nov 21, 2016
c796fdd
Update to avoid constant zookeeper restart.
saheemg Nov 21, 2016
704eafc
Merge pull request #2 from InfrastructureEngineering/addInstanceId
yogeswaran Nov 21, 2016
515f950
Make sure to no include ensemble when using dynamic config.
saheemg Apr 7, 2017
08fd2cd
review comment.
saheemg Apr 7, 2017
b464968
Merge pull request #3 from InfrastructureEngineering/betterZookeeper3…
yogeswaran Apr 7, 2017
aa74d25
Revert "Make sure to no include ensemble when using dynamic config."
saheemg Apr 7, 2017
3f76335
Merge pull request #4 from InfrastructureEngineering/revert-3-betterZ…
saheemg Apr 7, 2017
8b28885
review comment
saheemg Apr 10, 2017
2bc6d1e
removed extra space.
saheemg Apr 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libraries/zookeeper_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class ZookeeperConfig < Chef::Resource
attribute(:group, kind_of: String, default: 'zookeeper')

attribute(:instance_name, kind_of: String, required: true)
attribute(:instance_id, kind_of: Integer, required: false)
attribute(:data_dir, kind_of: String, default: '/var/lib/zookeeper')
attribute(:client_port, kind_of: Integer, default: 2181)
attribute(:leader_port, kind_of: Integer, default: 2888)
Expand All @@ -34,7 +35,11 @@ class ZookeeperConfig < Chef::Resource
attribute(:properties, option_collector: true, default: {})

def myid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would implement this slightly differently. I would set the default value of the instance_id attribute to be the index of the element in the ensemble array. After that we simply add an alias to the method so that #myid keeps on working.

attribute(:instance_id, kind_of: Integer, default: lazy { ensemble.index(instance_name).next.to_s })
alias_method :myid, :instance_id

ensemble.index(instance_name).next.to_s
if instance_id != nil
instance_id.to_s
else
ensemble.index(instance_name).next.to_s
end
end

# Outputs the +properties+ in the Java Properties file format. This is
Expand Down