Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scheduleAtFixedRate when evicting with scheduleWithFixedDelay from the connection pools. #534

Conversation

kennethshackleton
Copy link
Member

Screenshot 2024-06-25 at 08 10 54

… for single object pool.

Signed-off-by: Kenneth J. Shackleton <[email protected]>
@kennethshackleton kennethshackleton force-pushed the replace-scheduleAtFixedRate branch from ae424ec to 5a58997 Compare June 25, 2024 07:24
@kennethshackleton
Copy link
Member Author

> Task :selekt-java:test

CommonObjectPoolTest > interleavedBorrowSchedulesEvictionIfCancelled() FAILED
    org.opentest4j.AssertionFailedError: expected: <2> but was: <0>
        at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
        at app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
        at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
        at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1135)
        at app//kotlin.test.junit5.JUnit5Asserter.assertEquals(JUnitSupport.kt:32)
        at app//kotlin.test.AssertionsKt__AssertionsKt.assertEquals(Assertions.kt:63)
        at app//kotlin.test.AssertionsKt.assertEquals(Unknown Source)
        at app//kotlin.test.AssertionsKt__AssertionsKt.assertEquals$default(Assertions.kt:62)
        at app//kotlin.test.AssertionsKt.assertEquals$default(Unknown Source)
        at app//com.bloomberg.selekt.pools.CommonObjectPoolTest.interleavedBorrowSchedulesEvictionIfCancelled(CommonObjectPoolTest.kt:[396](https://github.com/bloomberg/selekt/actions/runs/10430699110/job/28889539510?pr=534#step:12:397))

CommonObjectPoolTest > evictionFailsIfCancelled() FAILED
    org.opentest4j.AssertionFailedError: expected: <com.bloomberg.selekt.pools.PooledObject@b6b02c1> but was: <com.bloomberg.selekt.pools.PooledObject@924cc5d>
        at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
        at app//org.junit.jupiter.api.AssertSame.failNotSame(AssertSame.java:48)
        at app//org.junit.jupiter.api.AssertSame.assertSame(AssertSame.java:37)
        at app//org.junit.jupiter.api.Assertions.assertSame(Assertions.java:2787)
        at app//kotlin.test.junit5.JUnit5Asserter.assertSame(JUnitSupport.kt:40)
        at app//kotlin.test.AssertionsKt__AssertionsKt.assertSame(Assertions.kt:97)
        at app//kotlin.test.AssertionsKt.assertSame(Unknown Source)
        at app//kotlin.test.AssertionsKt__AssertionsKt.assertSame$default(Assertions.kt:96)
        at app//kotlin.test.AssertionsKt.assertSame$default(Unknown Source)
        at app//com.bloomberg.selekt.pools.CommonObjectPoolTest.evictionFailsIfCancelled(CommonObjectPoolTest.kt:477)

> Task :selekt-android:compileDebugUnitTestKotlin
> Task :selekt-android:processDebugUnitTestJavaRes
> Task :selekt-android:compileDebugUnitTestJavaWithJavac


437 tests completed, 2 failed
> Task :selekt-java:test

Copy link

sonarqubecloud bot commented Sep 1, 2024

@kennethshackleton kennethshackleton changed the title Replace scheduleAtFixedRate when evicting with scheduleWithFixedDelay for single object pool. Replace scheduleAtFixedRate when evicting with scheduleWithFixedDelay from the connection pools. Sep 1, 2024
@kennethshackleton kennethshackleton marked this pull request as ready for review September 1, 2024 14:40
@kennethshackleton kennethshackleton requested a review from a team as a code owner September 1, 2024 14:40
@kennethshackleton kennethshackleton merged commit 2204e07 into bloomberg:main Sep 1, 2024
4 checks passed
@kennethshackleton kennethshackleton deleted the replace-scheduleAtFixedRate branch September 1, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant