Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support advanced zap configuration #124

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented Oct 5, 2022

*Issue number of the reported bug or feature request: #123 *

Describe your changes

  1. Removed the nasty DEBUG environment variable that is loaded outside of swagger's parser.
  2. Added a command line argument --zap-config that points to a valid json zap config file
  3. Added a /config folder to store the zap config file
  4. Added a default zap config file under config/zap.json

Testing performed
Loaded different zap configuration files such as zap.prod.json, zap.dev.json to test that the log level and outputPaths are the correct ones.

@maxime1907 maxime1907 changed the title feat: support zap config file feat: support advanced zap configuration Oct 5, 2022
@maxime1907 maxime1907 force-pushed the feat-config-zap branch 2 times, most recently from 757b9db to 875cfba Compare October 5, 2022 13:00
@maxime1907
Copy link
Contributor Author

cc @seeker89

@seeker89
Copy link
Contributor

seeker89 commented Oct 5, 2022

Hey @maxime1907 thanks for the PR!

Why was the DEBUG gate "nasty"?

I like adding the support for zap config file, but I'd prefer goldpinger to start (say with dev defaults) if none is provided - from the quick look I had it looks like it will now fail if there is none?

@maxime1907
Copy link
Contributor Author

Hey @maxime1907 thanks for the PR!

Why was the DEBUG gate "nasty"?

I like adding the support for zap config file, but I'd prefer goldpinger to start (say with dev defaults) if none is provided - from the quick look I had it looks like it will now fail if there is none?

Hey!
I used the word nasty because i saw this comment in the code:

// We haven't parsed flags at this stage and that might be error prone

Yes it will be failing if no option is provided but i can make it work so that it loads default dev values no problem!

@maxime1907
Copy link
Contributor Author

done! 🙂 @seeker89

@maxime1907
Copy link
Contributor Author

Any updates @seeker89 ? ^^

Makefile Outdated
@@ -1,5 +1,5 @@
name ?= goldpinger
version ?= v3.4.0
version ?= v3.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will go out as v3.7.0

@seeker89
Copy link
Contributor

Hey @maxime1907 sorry for the delay. Looks good. Please bump the version to 3.7.0 and let's get that money!

@maxime1907
Copy link
Contributor Author

Hey @maxime1907 sorry for the delay. Looks good. Please bump the version to 3.7.0 and let's get that money!

Done @seeker89 !

@seeker89 seeker89 merged commit 9536355 into bloomberg:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants