-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support advanced zap configuration #124
Conversation
757b9db
to
875cfba
Compare
cc @seeker89 |
875cfba
to
9083515
Compare
Hey @maxime1907 thanks for the PR! Why was the I like adding the support for zap config file, but I'd prefer goldpinger to start (say with dev defaults) if none is provided - from the quick look I had it looks like it will now fail if there is none? |
Hey!
Yes it will be failing if no option is provided but i can make it work so that it loads default dev values no problem! |
9083515
to
3ca4557
Compare
done! 🙂 @seeker89 |
Any updates @seeker89 ? ^^ |
Makefile
Outdated
@@ -1,5 +1,5 @@ | |||
name ?= goldpinger | |||
version ?= v3.4.0 | |||
version ?= v3.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will go out as v3.7.0
Hey @maxime1907 sorry for the delay. Looks good. Please bump the version to 3.7.0 and let's get that money! |
Signed-off-by: Maxime Leroy <[email protected]>
3ca4557
to
a913318
Compare
Done @seeker89 ! |
*Issue number of the reported bug or feature request: #123 *
Describe your changes
DEBUG
environment variable that is loaded outside of swagger's parser.--zap-config
that points to a valid json zap config file/config
folder to store the zap config fileconfig/zap.json
Testing performed
Loaded different zap configuration files such as
zap.prod.json
,zap.dev.json
to test that the log level and outputPaths are the correct ones.