Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP #118

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

WIP #118

wants to merge 20 commits into from

Conversation

rubensayshi
Copy link
Contributor

@rubensayshi rubensayshi commented Apr 19, 2018 •
edited
Loading

  • refactored all wallet related tests to no longer do HTTP calls.
  • refactored many other tests to also no longer do HTTP calls.
  • moved/copied all tests that still do HTTP calls to tests/IntegrationTests.

@rubensayshi rubensayshi force-pushed the test-refactoring branch 2 times, most recently from c5b8833 to 68698f7 Compare April 19, 2018 15:24
@rubensayshi rubensayshi force-pushed the test-refactoring branch 6 times, most recently from 976e08f to 780b07b Compare April 20, 2018 08:40
@rubensayshi rubensayshi force-pushed the test-refactoring branch 2 times, most recently from 5821f07 to 8f82d40 Compare April 20, 2018 08:44
@rubensayshi rubensayshi requested a review from afk11 April 20, 2018 12:26
@afk11 afk11 force-pushed the test-refactoring branch from 313574d to c280b20 Compare August 8, 2018 14:20
@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues, 14 updated code elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afk11 afk11 Awaiting requested review from afk11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubensayshi @scrutinizer-notifier