Implemented an interpretation stub for failed transactions #2373
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc |
|
Hello @NikitaSavik, i have made this PR awaiting your approval. |
|
@IamLRBA Can you mark PR as "Ready for review" please? |
isstuev
requested changes
Dec 9, 2024
| secondRow={ titleSecondRow } | ||
| /> | ||
| <p style={{ color: 'red', fontWeight: 'bold', marginTop: '20px' }}> | ||
| Address failed to call method on address. |
There was a problem hiding this comment.
Hi! It's not exactly what the issue is about.
The idea was to implement a stub for transaction with a failed status, not an error state of the page.
Also, it has to be not the plain text, but addresses and method name from the transaction data.
And we use chakra-ui and variables for colors and paddings, so styling is not correct also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this adjusted code:
If an error occurs and showDegradedView is false, the code checks whether the error is custom. If not, it displays the message "Address failed to call method on address" in bold, red text.
The error message is wrapped in a div alongside other content like the
TextAdandPageTitle, ensuring the page structure is consistent.