Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: nodejs docs #154

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Conversation

luislucena16
Copy link
Contributor

@luislucena16 luislucena16 commented Dec 20, 2023

hey @0xneves all nodejs documentation is already added!

PR: #139

closes #139

Copy link
Contributor

@0xneves 0xneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @luislucena16 In recent readme update at #148 there were updates that conflicts with this PR. Please update the branch prior to submitting this PR.

@luislucena16
Copy link
Contributor Author

hey @0xneves the branch is already up to date! i checked it!
branch updated

@0xneves
Copy link
Contributor

0xneves commented Dec 22, 2023

hey @0xneves the branch is already up to date! i checked it! branch updated

Yoo @luislucena16, your fork might not be up to date with the mainstream. Check the TL;DR, it's on the top, and yours is on the bottom.
I did a diff checker where you can see the differences.

@luislucena16
Copy link
Contributor Author

luislucena16 commented Dec 22, 2023

hey @0xneves I think it's ready, I've checked how it is in main

@0xneves
Copy link
Contributor

0xneves commented Dec 23, 2023

It is still different from the main branch :(
Don't just copy-paste the tldr into your commit. Try copying the main branch's readme, then add your changes to it.

image

@luislucena16
Copy link
Contributor Author

hey @0xneves done! check it

Copy link
Contributor

@0xneves 0xneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes after a slightly change on the installation part to make it smaller and linear

@0xneves 0xneves merged commit 305bfe3 into blockful-io:main Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add full NodeJS documentation in the README.md file
2 participants