feat(Revocation): [#715] encodeURI assertionId

blockchain-certificates · Sep 5, 2020 · fb7c24e · fb7c24e
1 parent 73afc13
commit fb7c24e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/domain/verifier/useCases/getRevokedAssertions.ts b/src/domain/verifier/useCases/getRevokedAssertions.ts
@@ -15,7 +15,7 @@ export default async function getRevokedAssertions (revocationListUrl: string, a
   const errorMessage: string = getText('errors', 'getRevokedAssertions');
 
   if (assertionId) {
-    revocationListUrl = safelyAppendUrlParameter(revocationListUrl, ASSERTION_ID_NAME, assertionId);
+    revocationListUrl = safelyAppendUrlParameter(revocationListUrl, ASSERTION_ID_NAME, encodeURIComponent(assertionId));
   }
 
   const response: any = await request({ url: revocationListUrl }).catch(() => {

diff --git a/test/application/domain/verifier/useCases/getRevokedAssertions.test.js b/test/application/domain/verifier/useCases/getRevokedAssertions.test.js
@@ -30,10 +30,10 @@ describe('Verifier domain getRevokedAssertions use case test suite', function ()
     describe('and an assertionId', function () {
       it('should request the correct URL with the appended assertionId', async function () {
         stubRequest.resolves(revokedAssertionsAssertionString);
-        const fixtureAssertionId = 'fixture-assertion-id';
+        const fixtureAssertionId = 'https://fixture-assertion-id.domain.tld';
         await getRevokedAssertions(issuerIdFixture, fixtureAssertionId);
         expect(stubRequest.getCall(0).args[0]).toEqual({
-          url: 'http://domain.tld/path?assertionId=fixture-assertion-id'
+          url: 'http://domain.tld/path?assertionId=https%3A%2F%2Ffixture-assertion-id.domain.tld'
         });
       });
     });