Skip to content

Commit

Permalink
HotFix: patch for adding timestamp to join (#331)
Browse files Browse the repository at this point in the history
* patch for adding timestamp to join

* bumped up version tag
  • Loading branch information
jfederico authored Jan 27, 2021
1 parent 04f56a3 commit 5aed834
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
2.3.5 (2019042010)
Bug: Fix for issue with users joining meetings with static URLs.

2.3.4 (2019042009)
Bug: Fix for issue with wrong role ids in Website Administration (CONTRIB-8047).
Bug: Fix for issue with notification when activity is updated not respecting enrolment status (CONTRIB-8046).
Expand Down
3 changes: 3 additions & 0 deletions RELEASENOTES
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
2.3.5 (2019042010)
Bug: Fix for issue with users joining meetings with static URLs.

2.3.4 (2019042009)
Bug: Fix for issue with wrong role ids in Website Administration (CONTRIB-8047).
Bug: Fix for issue with notification when activity is updated not respecting enrolment status (CONTRIB-8046).
Expand Down
2 changes: 1 addition & 1 deletion bbb_view.php
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ function bigbluebutton_bbb_view_join_meeting($bbbsession, $bigbluebuttonbn, $ori
$password = $bbbsession['modPW'];
}
$joinurl = bigbluebuttonbn_get_join_url($bbbsession['meetingid'], $bbbsession['username'],
$password, $bbbsession['logoutURL'], null, $bbbsession['userID'], $bbbsession['clienttype']);
$password, $bbbsession['logoutURL'], null, $bbbsession['userID'], $bbbsession['clienttype'], $meetinginfo['createTime']);
// Moodle event logger: Create an event for meeting joined.
bigbluebuttonbn_event_log(\mod_bigbluebuttonbn\event\events::$events['meeting_join'], $bigbluebuttonbn);
// Internal logger: Instert a record with the meeting created.
Expand Down
5 changes: 4 additions & 1 deletion locallib.php
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
* @return string
*/
function bigbluebuttonbn_get_join_url($meetingid, $username, $pw, $logouturl, $configtoken = null,
$userid = null, $clienttype = BIGBLUEBUTTON_CLIENTTYPE_FLASH) {
$userid = null, $clienttype = BIGBLUEBUTTON_CLIENTTYPE_FLASH, $createtime = null) {
$data = ['meetingID' => $meetingid,
'fullName' => $username,
'password' => $pw,
Expand All @@ -117,6 +117,9 @@ function bigbluebuttonbn_get_join_url($meetingid, $username, $pw, $logouturl, $c
if (!is_null($userid)) {
$data['userID'] = $userid;
}
if (!is_null($createtime)) {
$data['createTime'] = $createtime;
}
return \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('join', $data);
}

Expand Down
4 changes: 2 additions & 2 deletions version.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@

defined('MOODLE_INTERNAL') || die;

$plugin->version = 2019042009;
$plugin->version = 2019042010;
$plugin->requires = 2016120500;
$plugin->cron = 0;
$plugin->component = 'mod_bigbluebuttonbn';
$plugin->maturity = MATURITY_STABLE;
$plugin->release = '2.3.4';
$plugin->release = '2.3.5';

0 comments on commit 5aed834

Please sign in to comment.