MB-58033: Support for custom datetime layouts #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
Likith101 and
moshaad7
Thejas-bhat
requested changes
Sep 6, 2023
abhinavdangeti
previously approved these changes
Sep 7, 2023
Thejas-bhat
previously approved these changes
Sep 13, 2023
abhinavdangeti
requested changes
Sep 13, 2023
|
Also, not sure how you rebased this, but it seems you've cherry-picked a bunch of commits that have already been merged into this PR. Can you rebase over master and simply cherry-pick your commits and force push here. |
abhinavdangeti
force-pushed
the
MB-58033
branch
from
0f64ed5 to
0b1144e
Compare
|
@CascadingRadium I force-pushed all your commits over rebased master to avoid unnecessary cherry-picks of everything in between. Should you need to push more code here, make sure you start from a clean local branch checking-out the latest of |
abhinavdangeti
approved these changes
Sep 13, 2023
Thejas-bhat
pushed a commit
that referenced
this pull request
Oct 12, 2023
## Jira [MB-58033](https://issues.couchbase.com/browse/MB-58033) ## Description - Add 'percentstyle' date time layout format that mimics 'strftime' used for date time layout specification in C and Python. - Add 'isostyle' date time layout format that attempts to mimic 'DateTimeFormatter' which is used to specify date time layouts in Java. - Added unit tests --------- Co-authored-by: Abhinav Dangeti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
MB-58033
Description