search/searcher: fix dropped test errors

blevesearch · Oct 11, 2023 · 06631b3 · 06631b3
1 parent 840fde5
commit 06631b3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/search/searcher/search_boolean_test.go b/search/searcher/search_boolean_test.go
@@ -205,6 +205,9 @@ func TestBooleanSearch(t *testing.T) {
 		t.Fatal(err)
 	}
 	conjunctionSearcher7, err := NewConjunctionSearcher(nil, twoDocIndexReader, []search.Searcher{martyTermSearcher7, booleanSearcher7}, explainTrue)
+	if err != nil {
+		t.Fatal(err)
+	}
 
 	// test 7
 	beerTermSearcher8, err := NewTermSearcher(nil, twoDocIndexReader, "beer", "desc", 1.0, explainTrue)

diff --git a/search/searcher/search_conjunction_test.go b/search/searcher/search_conjunction_test.go
@@ -378,7 +378,7 @@ func testScorchCompositeSearchOptimizationsHelper(
 
 		next, err := cs.Next(ctx)
 		i := 0
-		for err == nil && next != nil {
+		for next != nil {
 			docID, err := indexReader.ExternalID(next.IndexInternalID)
 			if err != nil {
 				t.Fatal(err)
@@ -391,8 +391,10 @@ func testScorchCompositeSearchOptimizationsHelper(
 					t.Errorf("missing %s", string(docID))
 				}
 			}
-
 			next, err = cs.Next(ctx)
+			if err != nil {
+				t.Fatalf("error iterating searcher: %v", err)
+			}
 			i++
 		}
 

diff --git a/search/searcher/search_term_range_test.go b/search/searcher/search_term_range_test.go
@@ -244,19 +244,19 @@ func TestTermRangeSearchTooManyTerms(t *testing.T) {
 	}
 	next, err := searcher.Next(ctx)
 	i := 0
-	for err == nil && next != nil {
+	for next != nil {
 		extId, err := scorchReader.ExternalID(next.IndexInternalID)
 		if err != nil {
 			t.Fatal(err)
 		}
 		got = append(got, extId)
 		ctx.DocumentMatchPool.Put(next)
 		next, err = searcher.Next(ctx)
+		if err != nil {
+			t.Fatalf("error iterating searcher: %v", err)
+		}
 		i++
 	}
-	if err != nil {
-		t.Fatalf("error iterating searcher: %v", err)
-	}
 	err = searcher.Close()
 	if err != nil {
 		t.Fatal(err)