Add l18n support to the Cron component #94
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release brings support for: - String localization - 24 hour time format
New tests: - It can translate a cron to a supported locale - It defaults to English with an unknown locale - It can display time in the 24-hour format
New tests: - It can translate a cron to a supported locale - It defaults to English with an unknown locale - It can display time in the 24-hour format
|
Regarding the 24-hour time format option, I'm not fully satisfied with the Cleaner solutions are welcome! |
driesvints
requested changes
Feb 13, 2021
Reorder the constructor arguments to prevent breaking changes. Cf: blade-ui-kit#94 (review)
danharrin
reviewed
Feb 2, 2022
| /** @var bool */ | ||
| public $use24hour = false; | ||
|
|
||
| public function __construct(string $schedule, bool $human = false, string $locale = 'en', bool $use24hour = false) |
There was a problem hiding this comment.
Maybe $is24Hour is closer to convention?
Suggested change
| public function __construct(string $schedule, bool $human = false, string $locale = 'en', bool $use24hour = false) | |
| public function __construct(string $schedule, bool $human = false, string $locale = 'en', bool $is24Hour = false) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds internationalization support to the Cron component:
These are new features brought by the new 0.2.0 release of cron-translator.
PS: The documentation PR is here.