Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve icons #802

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Improve icons #802

merged 9 commits into from
Oct 31, 2023

Conversation

black7375
Copy link
Owner

Describe the PR

Awesome icon pack by @zapSNH

PR Type

  • Add: Add feature or enhanced.
  • Fix: Bug fix or change default values.
  • Clean: Refactoring.
  • Doc: Update docs.

Related Issue

#213

Screenshots

Additional context

The commit record was preserved as much as possible using git cherrypick.
It is still necessary to replace the default icons.

zapSNH added 3 commits October 23, 2023 01:32
@zapSNH @black7375
Add files
ab610eb 
Conflicts:
	icons/add-device.svg
	icons/arrow-between-down.svg
	icons/arrow-repeat-all.svg
	icons/arrow-sort-down-lines.svg
	icons/arrow-swap.svg
	icons/auto-fit-width.svg
	icons/book-add.svg
	icons/book.svg
	icons/bookmark-multiple.svg
	icons/bookmarksMenu-open.svg
	icons/bookmarksMenu-open2.svg
	icons/bookmarksToolbar-open.svg
	icons/broom.svg
	icons/bug.svg
	icons/calendar-agenda.svg
	icons/code.svg
	icons/command-frames.svg
	icons/command-pick.svg
	icons/container-openin-16.svg
	icons/content-view.svg
	icons/copy-select.svg
	icons/dashboard.svg
	icons/datarestore.svg
	icons/datastore.svg
	icons/developer.svg
	icons/dismiss-filled.svg
	icons/document-css.svg
	icons/document-endnote.svg
	icons/document-landscape-split-hint.svg
	icons/document-search.svg
	icons/drawer-arrow-download.svg
	icons/edit-copy.svg
	icons/edit-paste-go.svg
	icons/edit-paste-search.svg
	icons/enter-fullscreen.svg
	icons/exit-fullscreen.svg
	icons/eye-hide.svg
	icons/eye-show.svg
	icons/eye-tracking-off.svg
	icons/fluid.svg
	icons/folder-globe.svg
	icons/folder-open.svg
	icons/folder.svg
	icons/highlight.svg
	icons/image-add.svg
	icons/image-alt-text.svg
	icons/image-arrow-counterclockwise.svg
	icons/image-copy.svg
	icons/image.svg
	icons/key-multiple.svg
	icons/link-square.svg
	icons/link.svg
	icons/lock-closed.svg
	icons/mail-inbox-all.svg
	icons/mail-inbox.svg
	icons/menu-check.svg
	icons/movetowindow-16.svg
	icons/new-tab-forward.svg
	icons/new-tab-multiple.svg
	icons/new-tab-skip-forward.svg
	icons/password-hide.svg
	icons/password.svg
	icons/performance.svg
	icons/play.svg
	icons/plug-disconnected.svg
	icons/quit.svg
	icons/redo.svg
	icons/resize-image.svg
	icons/resize.svg
	icons/restore-session.svg
	icons/screenshot.svg
	icons/select-all-on.svg
	icons/send-to-device.svg
	icons/send.svg
	icons/shield-task.svg
	icons/sign-out.svg
	icons/star-line-horizontal.svg
	icons/tab-copy.svg
	icons/tab-desktop-multiple-bottom.svg
	icons/tab-unload.svg
	icons/tab.svg
	icons/tag-open.svg
	icons/text-direction-horizontal-ltr.svg
	icons/text-number-format.svg
	icons/text-proofing-tools.svg
	icons/text-sort-ascending.svg
	icons/time-picker.svg
	icons/timer10.svg
	icons/toolbar.svg
	icons/toolbarButton-download.svg
	icons/toolbarButton-upload.svg
	icons/toolbox.svg
	icons/undo.svg
	icons/video-clip.svg
	icons/video-snapshot.svg
	icons/video.svg
	icons/whatsnew.svg
	icons/window-dev-tools.svg
	icons/wrench-filled.svg

Changes to be committed:
	modified:   icons/add-device.svg
	modified:   icons/arrow-between-down.svg
	modified:   icons/arrow-repeat-all.svg
	modified:   icons/arrow-sort-down-lines.svg
	modified:   icons/arrow-swap.svg
	modified:   icons/auto-fit-width.svg
	modified:   icons/book-add.svg
	modified:   icons/book.svg
	modified:   icons/bookmark-multiple.svg
	new file:   icons/bookmarks-toolbar-alt.svg
	new file:   icons/bookmarks-toolbar.svg
	modified:   icons/bookmarksMenu-open.svg
	modified:   icons/bookmarksMenu-open2.svg
	new file:   icons/bookmarksToolbar-open-alt.svg
	modified:   icons/bookmarksToolbar-open.svg
	modified:   icons/broom.svg
	modified:   icons/bug.svg
	modified:   icons/calendar-agenda.svg
	new file:   icons/characterEncoding.svg
	modified:   icons/code.svg
	modified:   icons/command-frames.svg
	modified:   icons/command-pick.svg
	new file:   icons/command-reponsivemode.svg
	modified:   icons/container-openin-16.svg
	modified:   icons/content-view.svg
	modified:   icons/copy-select.svg
	modified:   icons/dashboard.svg
	modified:   icons/datarestore.svg
	modified:   icons/datastore.svg
	modified:   icons/developer.svg
	new file:   icons/device-desktop.svg
	new file:   icons/device-phone.svg
	new file:   icons/device-tablet.svg
	new file:   icons/device-tv.svg
	new file:   icons/device-vr.svg
	modified:   icons/dismiss-filled.svg
	modified:   icons/document-css.svg
	modified:   icons/document-endnote.svg
	modified:   icons/document-landscape-split-hint.svg
	modified:   icons/document-search.svg
	modified:   icons/drawer-arrow-download.svg
	modified:   icons/edit-copy.svg
	new file:   icons/edit-cut.svg
	modified:   icons/edit-paste-go.svg
	modified:   icons/edit-paste-search.svg
	new file:   icons/edit-paste.svg
	modified:   icons/enter-fullscreen.svg
	modified:   icons/exit-fullscreen.svg
	modified:   icons/eye-hide.svg
	modified:   icons/eye-show.svg
	modified:   icons/eye-tracking-off.svg
	modified:   icons/fluid.svg
	modified:   icons/folder-globe.svg
	modified:   icons/folder-open.svg
	modified:   icons/folder.svg
	new file:   icons/forget.svg
	modified:   icons/highlight.svg
	modified:   icons/image-add.svg
	modified:   icons/image-alt-text.svg
	modified:   icons/image-arrow-counterclockwise.svg
	modified:   icons/image-copy.svg
	modified:   icons/image.svg
	new file:   icons/ion.svg
	modified:   icons/key-multiple.svg
	modified:   icons/link-square.svg
	modified:   icons/link.svg
	modified:   icons/lock-closed.svg
	modified:   icons/mail-inbox-all.svg
	modified:   icons/mail-inbox.svg
	new file:   icons/mail.svg
	modified:   icons/menu-check.svg
	modified:   icons/movetowindow-16.svg
	new file:   icons/new-tab-forward-photon.svg
	modified:   icons/new-tab-forward.svg
	new file:   icons/new-tab-multiple-photon.svg
	modified:   icons/new-tab-multiple.svg
	new file:   icons/new-tab-photon.svg
	new file:   icons/new-tab-skip-forward-photon.svg
	modified:   icons/new-tab-skip-forward.svg
	new file:   icons/new-tab.svg
	modified:   icons/password-hide.svg
	modified:   icons/password.svg
	new file:   icons/paste-text.svg
	new file:   icons/paste-url.svg
	modified:   icons/performance.svg
	modified:   icons/play.svg
	modified:   icons/plug-disconnected.svg
	modified:   icons/quit.svg
	modified:   icons/redo.svg
	modified:   icons/resize-image.svg
	modified:   icons/resize.svg
	modified:   icons/restore-session.svg
	new file:   icons/screenshoot-1.svg
	modified:   icons/screenshot.svg
	modified:   icons/select-all-on.svg
	modified:   icons/send-to-device.svg
	modified:   icons/send.svg
	modified:   icons/shield-task.svg
	modified:   icons/sign-out.svg
	modified:   icons/star-line-horizontal.svg
	new file:   icons/tab-copy-photon.svg
	modified:   icons/tab-copy.svg
	modified:   icons/tab-desktop-multiple-bottom.svg
	new file:   icons/tab-desktop-multiple.svg
	modified:   icons/tab-unload.svg
	modified:   icons/tab.svg
	new file:   icons/tag-open-content.svg
	modified:   icons/tag-open.svg
	modified:   icons/text-direction-horizontal-ltr.svg
	modified:   icons/text-number-format.svg
	modified:   icons/text-proofing-tools.svg
	modified:   icons/text-sort-ascending.svg
	modified:   icons/time-picker.svg
	modified:   icons/timer10.svg
	modified:   icons/toolbar.svg
	modified:   icons/toolbarButton-download.svg
	modified:   icons/toolbarButton-upload.svg
	modified:   icons/toolbox.svg
	modified:   icons/undo.svg
	modified:   icons/video-clip.svg
	modified:   icons/video-snapshot.svg
	modified:   icons/video.svg
	modified:   icons/whatsnew.svg
	modified:   icons/window-dev-tools.svg
	modified:   icons/wrench-filled.svg
@zapSNH @black7375
Fix some icons + add accessibility icon
f77e1da
@zapSNH @black7375
Better accessibility icon + no tracking icon
0fa6f75
@black7375 black7375 changed the title Imporve icons Improve icons Oct 22, 2023
@zapSNH
Copy link
Contributor

zapSNH commented Oct 25, 2023

screenshoot-1.svg had some minor issues (it was slightly cut off to the right) and was misspelled (screenshoot-1.svg > screenshot-1.svg). Could you please add those fixes?

https://github.com/zapSNH/lepton-icons/

@black7375 black7375 marked this pull request as ready for review October 29, 2023 10:11
@zapSNH
Copy link
Contributor

zapSNH commented Oct 29, 2023

It seems like you didn't push zapSNH/lepton-icons@beba3f9 which fixes the screenshot icon being slightly clipped to the right.

@black7375
Copy link
Owner Author

@zapSNH Now updated to your icon to apply.
Would you like to check if there's a missing part?
image

@zapSNH
Copy link
Contributor

zapSNH commented Oct 29, 2023 •
edited
Loading

More tools in the app menu
image

Select all tabs
image

@black7375
Copy link
Owner Author

Thanks, that's a applied.

@black7375
Copy link
Owner Author

Can we merge this PR?

@zapSNH
Copy link
Contributor

zapSNH commented Oct 31, 2023

Sure.

@black7375 black7375 merged commit ede786a into master Oct 31, 2023
1 check passed
@black7375
Copy link
Owner Author

Once again, thank you for your great contribution

black7375 added a commit that referenced this pull request Nov 6, 2023
@black7375
Fix: Icons - Multiple tabbar mode #802
382a289
black7375 added a commit that referenced this pull request Nov 19, 2023
@black7375
Docs: Update to CREADITS #790 #794 #797 #802 #813
4eb9c3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@black7375 @zapSNH