Skip to content

Commit

Permalink
Fix: Padding - Bookmark & History empty align #888
Browse files Browse the repository at this point in the history
  • Loading branch information
black7375 committed May 18, 2024
1 parent 2895809 commit f44ed17
Showing 3 changed files with 22 additions and 0 deletions.
12 changes: 12 additions & 0 deletions css/leptonChrome.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions css/leptonChromeESR.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/icons/layout/_panel.scss
Original file line number Diff line number Diff line change
@@ -33,6 +33,11 @@
.toolbaritem-combined-buttons:not(.unified-extensions-item) > .subviewbutton:not(.subviewbutton-iconic) > .toolbarbutton-text {
padding-inline-start: 0 !important;
}
#panelMenu_bookmarksMenu .subviewbutton[disabled="true"],
#appMenu_historyMenu .subviewbutton[disabled="true"] {
margin-inline-start: 0 !important;
padding-inline-start: 0 !important;
}
#panelMenu_bookmarksMenu .subviewbutton[disabled="true"] .toolbarbutton-text,
#appMenu_historyMenu .subviewbutton[disabled="true"] .toolbarbutton-text {
padding-inline-start: var(--arrowpanel-menublank-padding) !important;

2 comments on commit f44ed17

@thunderstone135
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still showing a little misalignment 👇

Imgur

I changed the values to 👇

 #panelMenu_bookmarksMenu .subviewbutton[disabled="true"],
    #appMenu_historyMenu .subviewbutton[disabled="true"] {
-     margin-inline-start: 0 !important;
+     margin-inline-start: -7px !important;
-     padding-inline-start: 0 !important;
+     padding-inline-start: -7px !important;
    }

Now, it's showing the correct alignment 👇

Imgur

I hope this helps.

@thunderstone135
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I changed margin and padding to -4px.

#panelMenu_bookmarksMenu .subviewbutton[disabled="true"],
#appMenu_historyMenu .subviewbutton[disabled="true"] {
  margin-inline-start: -4px !important;
  padding-inline-start: -4px !important;
}

I don't know why it's like that on my system ¯|_ (ツ) _|¯

Please sign in to comment.