Skip to content

Commit

Permalink
Fix: Compatibility - Windows photon-style's compact mode with maximiz…
Browse files Browse the repository at this point in the history 
…ed top padding #384
  • Loading branch information
@black7375
black7375 committed Jun 6, 2022
1 parent d79cc9e commit e37743c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions css/leptonChrome.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@
margin-left: -1px;
}

/*= Titlebar Container Size at photon-style compact maximized #384 ===========*/
:root[tabsintitlebar][sizemode="maximized"] #titlebar {
appearance: unset !important;
}

/*= Disabled menu background color ===========================================*/
menuitem[disabled="true"],
menu[disabled="true"] {
Expand Down
5 changes: 5 additions & 0 deletions src/compatibility/_theme.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@
margin-left: -1px;
}

/*= Titlebar Container Size at photon-style compact maximized #384 ===========*/
:root[tabsintitlebar][sizemode="maximized"] #titlebar {
appearance: unset !important;
}

/*= Disabled menu background color ===========================================*/
menuitem,
menu {
Expand Down

4 comments on commit e37743c

@thunderstone135
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I just want to let you know that this commit re-opens the bug mentioned in #370 (comment).

Imgur

AFAIK, you fixed this issue with this code:

  @media (-moz-os-version: windows-win7),
    (-moz-platform: windows-win7),
    (-moz-os-version: windows-win8),
    (-moz-platform: windows-win8),
    (-moz-os-version: windows-win10),
    (-moz-platform: windows-win10) {
    :root[tabsintitlebar="true"][sizemode="maximized"] #navigator-toolbox {
      padding-top: 8px;
    }
  }

However, the code you introduced in this commit broke it.

To temporarily fix the issue, I did this:

  /*= Titlebar Container Size At Photon-Style Compact Maximized #384 ===========*/
  :root[tabsintitlebar][sizemode="maximized"] #titlebar {
>  /* appearance: unset !important; */
  }

Hopefully, you can provide a better fix than what I did.

@black7375
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting.
This issue is more tricky than I thought.

@thunderstone135
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got it. I just added the value of your previous fix to this commit:

  /*= Titlebar Container Size At Photon-Style Compact Maximized #384 ===========*/
  :root[tabsintitlebar][sizemode="maximized"] #titlebar {
   appearance: unset !important;
>  padding-top: 8px;
  }

After doing that, everything went back to normal.

@black7375
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I will test it at Win7/8/10, Mac, and Linux on the weekend.
Judging from what I've seen so far, many side effects have occurred.

Please sign in to comment.