Skip to content

Commit

Permalink
Fix: Tab - selected attribute compatibility #787
Browse files Browse the repository at this point in the history
`.tabbrowser *[selected="true"]` to `.tabbrowser *[selected]`
  • Loading branch information
black7375 committed Oct 1, 2023
1 parent a7cc5b8 commit cc55546
Show file tree
Hide file tree
Showing 9 changed files with 57 additions and 64 deletions.
38 changes: 18 additions & 20 deletions css/leptonChrome.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

45 changes: 20 additions & 25 deletions css/leptonChromeESR.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions src/tab/_container_tab.scss
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@
}

/* Pinned Tab - Titlechanged Indicator override */
.tabbrowser-tab:is([image], [pinned])[usercontextid] > .tab-stack > .tab-content[attention]:not([selected="true"]),
.tabbrowser-tab[usercontextid] > .tab-stack > .tab-content[pinned][titlechanged]:not([selected="true"]) {
.tabbrowser-tab:is([image], [pinned])[usercontextid] > .tab-stack > .tab-content[attention]:not([selected]),
.tabbrowser-tab[usercontextid] > .tab-stack > .tab-content[pinned][titlechanged]:not([selected]) {
/* Original: radial-gradient(circle, var(--attention-icon-color), var(--attention-icon-color) 2px, transparent 2px); */
--dotted-identity-image: radial-gradient(
circle,
Expand All @@ -89,36 +89,36 @@
background-position-x: var(--uc-titlechanged-container-position-x) !important;
}

.tabbrowser-tab:is([image], [pinned]) > .tab-stack > .tab-content[attention]:not([selected="true"]),
.tabbrowser-tab > .tab-stack > .tab-content[pinned][titlechanged]:not([selected="true"]) {
.tabbrowser-tab:is([image], [pinned]) > .tab-stack > .tab-content[attention]:not([selected]),
.tabbrowser-tab > .tab-stack > .tab-content[pinned][titlechanged]:not([selected]) {
/* Original: center bottom calc(6.5px + var(--tabs-navbar-shadow-size)); */
background-position-y: top var(--uc-container-position-y) !important;
}

/* Pinned Tab - Titlechanged & soundplaying */
.tabbrowser-tab:is([image], [pinned])[usercontextid]:is([soundplaying], [muted], [activemedia-blocked])
> .tab-stack
> .tab-content[attention]:not([selected="true"]),
> .tab-content[attention]:not([selected]),
.tabbrowser-tab[usercontextid]:is([soundplaying], [muted], [activemedia-blocked])
> .tab-stack
> .tab-content[pinned][titlechanged]:not([selected="true"]) {
> .tab-content[pinned][titlechanged]:not([selected]) {
--uc-titlechanged-container-position-x: calc(32% - 1px), calc(50% - 1px), calc(70% - 1px);
}
:root[uidensity="compact"]
.tabbrowser-tab:is([image], [pinned])[usercontextid]:is([soundplaying], [muted], [activemedia-blocked])
> .tab-stack
> .tab-content[attention]:not([selected="true"]),
> .tab-content[attention]:not([selected]),
:root[uidensity="compact"]
.tabbrowser-tab[usercontextid]:is([soundplaying], [muted], [activemedia-blocked])
> .tab-stack
> .tab-content[pinned][titlechanged]:not([selected="true"]) {
> .tab-content[pinned][titlechanged]:not([selected]) {
--uc-titlechanged-container-position-x: calc(30% - 1px), calc(50% - 1px), calc(70% - 1px);
}
}

@include Option("userChrome.tab.container.on_top") {
.tabbrowser-tab:is([image], [pinned]) > .tab-stack > .tab-content[attention]:not([selected="true"]),
.tabbrowser-tab > .tab-stack > .tab-content[pinned][titlechanged]:not([selected="true"]) {
.tabbrowser-tab:is([image], [pinned]) > .tab-stack > .tab-content[attention]:not([selected]),
.tabbrowser-tab > .tab-stack > .tab-content[pinned][titlechanged]:not([selected]) {
/* Original: center bottom calc(6.5px + var(--tabs-navbar-shadow-size)); */
background-position-y: top var(--uc-container-position-y-bottom) !important;
}
Expand Down
2 changes: 1 addition & 1 deletion src/tab/clipped_tab/_show_close_button_at_hover.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
> .tabbrowser-tab:not([pinned])
> .tab-stack
> .tab-content
> .tab-close-button:not([selected="true"]) {
> .tab-close-button:not([selected]) {
@include InlineBox(true);
}

Expand Down
2 changes: 1 addition & 1 deletion src/tab/selected_tab/_color_like_toolbar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
> #tabbrowser-arrowscrollbox
> .tabbrowser-tab
> .tab-stack
> .tab-background[selected="true"]:-moz-lwtheme {
> .tab-background[selected]:-moz-lwtheme {
/* Original: linear-gradient(var(--lwt-selected-tab-background-color, transparent), var(--lwt-selected-tab-background-color, transparent)), linear-gradient(var(--toolbar-bgcolor), var(--toolbar-bgcolor)), var(--lwt-header-image, none)
*/
background-image: linear-gradient(transparent, transparent),
Expand Down
2 changes: 1 addition & 1 deletion src/tab/selected_tab/_multi_selected.scss
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
outline-offset: -1px;
}

.tab-background[multiselected=true][selected=true] {
.tab-background[multiselected=true][selected] {
outline-width: 2px;
outline-offset: -2px;
}
Expand Down
4 changes: 2 additions & 2 deletions src/theme/system_default_theme/_mac.scss
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,13 @@
> #tabbrowser-arrowscrollbox
> .tabbrowser-tab
> .tab-stack
> .tab-background[selected="true"],
> .tab-background[selected],
:root[style*="--lwt-accent-color: rgb(28, 27, 34); --lwt-text-color: rgba(251, 251, 254);"][lwt-default-theme-in-dark-mode]
#tabbrowser-tabs:not([movingtab])
> #tabbrowser-arrowscrollbox
> .tabbrowser-tab
> .tab-stack
> .tab-background[selected="true"] {
> .tab-background[selected] {
background: color-mix(in srgb, rgb(255, 255, 255) 15%, -moz-dialog) !important;
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/theme/system_default_theme/_win7.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
#TabsToolbar:not(:-moz-lwtheme)
.tabbrowser-tab
> .tab-stack
> .tab-background:not([selected="true"], [multiselected]) {
> .tab-background:not([selected], [multiselected]) {
color: var(--background-color);
background-color: color-mix(in srgb, currentColor 60%, transparent);
}
#TabsToolbar:not(:-moz-lwtheme)
.tabbrowser-tab:hover
> .tab-stack
> .tab-background:not([selected="true"], [multiselected]) {
> .tab-background:not([selected], [multiselected]) {
background-color: color-mix(
in srgb,
currentColor 85%,
Expand Down
4 changes: 2 additions & 2 deletions src/theme/transparent/_general_element_background.scss
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@

.tabbrowser-tab
> .tab-stack
> .tab-background:not([selected="true"], [multiselected]) {
> .tab-background:not([selected], [multiselected]) {
background-color: var(--uc-frame-element-background);
}

#firefox-view-button:hover:not([open]) > .toolbarbutton-icon,
.tabbrowser-tab:hover
> .tab-stack
> .tab-background:not([selected="true"], [multiselected]) {
> .tab-background:not([selected], [multiselected]) {
background-color: var(--toolbarbutton-hover-background) !important; /* Original: color-mix(in srgb, currentColor 11%, transparent) */
}
}
Expand Down

0 comments on commit cc55546

Please sign in to comment.