fix(dnac): correctly passing objects in funcs, so primary address for…

… device gets updated correctly
bl4ko · Aug 23, 2024 · 67fd8d8 · 67fd8d8
1 parent e99ba7e
commit 67fd8d8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/internal/source/dnac/dnac_sync.go b/internal/source/dnac/dnac_sync.go
@@ -341,7 +341,7 @@ func (ds *DnacSource) syncDeviceInterface(nbi *inventory.NetboxInventory, ifaceI
 		return fmt.Errorf("add device interface: %s", err)
 	}
 
-	err = ds.addIPAddressToInterface(nbi, nbIface, iface)
+	err = ds.addIPAddressToInterface(nbi, nbIface, iface, ifaceDevice)
 	if err != nil {
 		ds.Logger.Errorf(ds.Ctx, "adding IP address: %s", err)
 	}
@@ -438,7 +438,7 @@ func (ds *DnacSource) getVlanModeAndAccessVlan(portMode, vlanID string) (*object
 	}
 }
 
-func (ds *DnacSource) addIPAddressToInterface(nbi *inventory.NetboxInventory, iface *objects.Interface, ifaceDetails dnac.ResponseDevicesGetAllInterfacesResponse) error {
+func (ds *DnacSource) addIPAddressToInterface(nbi *inventory.NetboxInventory, iface *objects.Interface, ifaceDetails dnac.ResponseDevicesGetAllInterfacesResponse, ifaceDevice *objects.Device) error {
 	if ifaceDetails.IPv4Address == "" || utils.SubnetsContainIPAddress(ifaceDetails.IPv4Address, ds.SourceConfig.IgnoredSubnets) {
 		return nil
 	}
@@ -488,7 +488,7 @@ func (ds *DnacSource) addIPAddressToInterface(nbi *inventory.NetboxInventory, if
 	// Set the interface as the primary IPv4 if it matches the device's management IP
 	deviceManagementIP := ds.Devices[ifaceDetails.DeviceID].ManagementIPAddress
 	if deviceManagementIP == ifaceDetails.IPv4Address {
-		deviceCopy := *iface.Device
+		deviceCopy := *ifaceDevice
 		deviceCopy.PrimaryIPv4 = nbIPAddress
 		_, err := nbi.AddDevice(ds.Ctx, &deviceCopy)
 		if err != nil {