disallow string type in GreaterThan and LessThan

bjd-php · Oct 15, 2020 · 89e1efe · 89e1efe
1 parent 444fcb1
commit 89e1efe
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/Constraint/Constraints/GreaterThan.php b/Constraint/Constraints/GreaterThan.php
@@ -45,7 +45,7 @@ protected function configureOptions(OptionsResolver $resolver): void
     {
         $resolver
             ->setRequired(['value'])
-            ->setAllowedTypes('value', ['numeric', 'string'])
+            ->setAllowedTypes('value', ['numeric'])
         ;
     }
 }
diff --git a/Constraint/Constraints/LessThan.php b/Constraint/Constraints/LessThan.php
@@ -45,7 +45,7 @@ protected function configureOptions(OptionsResolver $resolver): void
     {
         $resolver
             ->setRequired(['value'])
-            ->setAllowedTypes('value', ['numeric', 'string'])
+            ->setAllowedTypes('value', ['numeric'])
         ;
     }
 }
diff --git a/Tests/Constraint/Constraints/GreaterThanOrEqualTest.php b/Tests/Constraint/Constraints/GreaterThanOrEqualTest.php
@@ -20,7 +20,7 @@ public function testInvalidConfiguration(): void
         $this->expectException(InvalidOptionsException::class);
 
         new ParsleyAssert\GreaterThanOrEqual([
-            'value' => [],
+            'value' => 'foo',
         ]);
     }
 

diff --git a/Tests/Constraint/Constraints/GreaterThanTest.php b/Tests/Constraint/Constraints/GreaterThanTest.php
@@ -20,7 +20,7 @@ public function testInvalidConfiguration(): void
         $this->expectException(InvalidOptionsException::class);
 
         new ParsleyAssert\GreaterThan([
-            'value' => [],
+            'value' => 'foo',
         ]);
     }
 

diff --git a/Tests/Constraint/Constraints/LessThanOrEqualTest.php b/Tests/Constraint/Constraints/LessThanOrEqualTest.php
@@ -20,7 +20,7 @@ public function testInvalidConfiguration(): void
         $this->expectException(InvalidOptionsException::class);
 
         new ParsleyAssert\LessThanOrEqual([
-            'value' => [],
+            'value' => 'foo',
         ]);
     }
 
@@ -58,7 +58,7 @@ public function testNormalization(): void
 
         // string
         $constraint = new ParsleyAssert\LessThanOrEqual([
-            'value' => 10,
+            'value' => '10',
         ]);
 
         $this->assertSame([

diff --git a/Tests/Constraint/Constraints/LessThanTest.php b/Tests/Constraint/Constraints/LessThanTest.php
@@ -20,7 +20,7 @@ public function testInvalidConfiguration(): void
         $this->expectException(InvalidOptionsException::class);
 
         new ParsleyAssert\LessThan([
-            'value' => [],
+            'value' => 'foo',
         ]);
     }
 
@@ -58,7 +58,7 @@ public function testNormalization(): void
 
         // string
         $constraint = new ParsleyAssert\LessThan([
-            'value' => "10",
+            'value' => '10',
         ]);
 
         $this->assertSame([