Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference .net 8 for key connector #477

Merged
merged 1 commit into from
Nov 14, 2024
Merged

reference .net 8 for key connector #477

merged 1 commit into from
Nov 14, 2024

Conversation

jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented Nov 12, 2024

🎟️ Tracking

📔 Objective

Updates dotnet version in our docs for key connector.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jlf0dev jlf0dev requested a review from a team as a code owner November 12, 2024 20:09
Copy link

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 43a593e
Status: ✅  Deploy successful!
Preview URL: https://c46faf3c.contributing-docs.pages.dev
Branch Preview URL: https://key-connector-version.contributing-docs.pages.dev

View logs

Copy link

Logo
Checkmarx One – Scan Summary & Detailsf426f3e9-d7bd-4873-9b86-b154f49933dc

No New Or Fixed Issues Found

@jlf0dev jlf0dev merged commit 423b6dc into main Nov 14, 2024
9 checks passed
@jlf0dev jlf0dev deleted the key-connector-version branch November 14, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants