Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create labeler for ADR updates #464

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Create labeler for ADR updates #464

merged 1 commit into from
Oct 30, 2024

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Oct 29, 2024

📔 Objective

We would like better visibility internally to opened ADRs, so that team members can offer feedback through the Github PR, without tagging the entire engineering organization as reviewers.

To distinguish these ADRs from other updates to the repo, this change will add a adr label to the PR when there are changes in the /docs/architecture/adr directory.

This label will then be used in upstream automations to trigger notifications.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1dd505b
Status: ✅  Deploy successful!
Preview URL: https://f111af34.contributing-docs.pages.dev
Branch Preview URL: https://add-adr-label.contributing-docs.pages.dev

View logs

@trmartin4 trmartin4 marked this pull request as ready for review October 29, 2024 20:52
@trmartin4 trmartin4 requested a review from a team as a code owner October 29, 2024 20:52
@trmartin4 trmartin4 changed the title Create labeler Create labeler for ADR updates Oct 29, 2024
@trmartin4 trmartin4 merged commit 0aa59ae into main Oct 30, 2024
8 checks passed
@trmartin4 trmartin4 deleted the add-adr-label branch October 30, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants