Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR for integration identification #458

Merged
merged 11 commits into from
Oct 30, 2024
Merged

ADR for integration identification #458

merged 11 commits into from
Oct 30, 2024

Conversation

withinfocus
Copy link
Contributor

🎟️ Tracking

Originated from bot management discussions amongst leadership.

📔 Objective

ADR to enhance our server request pipeline with additional validations and registration of integrations.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

cloudflare-workers-and-pages bot commented Oct 23, 2024

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e255fc
Status: ✅  Deploy successful!
Preview URL: https://5e7cd4c6.contributing-docs.pages.dev
Branch Preview URL: https://integrations.contributing-docs.pages.dev

View logs

Copy link

github-actions bot commented Oct 23, 2024

Logo
Checkmarx One – Scan Summary & Detailsef7a075a-1406-4fbc-bc47-9cb49ccea64f

No New Or Fixed Issues Found

@withinfocus withinfocus marked this pull request as ready for review October 23, 2024 16:56
@withinfocus withinfocus requested a review from a team as a code owner October 23, 2024 16:56
Copy link
Member

@MGibson1 MGibson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My biggest concern here is there is nothing in place or specified here that will keep us honest in the future. I DO NOT want a system by which we can throttle alternative clients to the point of uselessness.

Co-authored-by: Matt Gibson <[email protected]>
@github-actions github-actions bot added the adr label Oct 30, 2024
@withinfocus withinfocus requested a review from MGibson1 October 30, 2024 13:15
@withinfocus withinfocus merged commit 3463505 into main Oct 30, 2024
9 checks passed
@withinfocus withinfocus deleted the integrations branch October 30, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants