-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SDK documentation #415
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d8a3685
Improve sdk documentation
Hinton d368406
Merge branch 'main' of github.com:bitwarden/contributing-docs into sdk
Hinton 249515e
Update contributing docs with local linking instructions
Hinton a868455
Fix property naming
Hinton a3b4385
Update android instructions
Hinton 506bc5a
Document client struct
Hinton 11b7e87
Add link to api docs
Hinton fb575ce
Merge branch 'main' into sdk
Hinton ff63e6b
Fix typo
Hinton d254815
Apply suggestions from code review
Hinton 6cf04be
Format
Hinton 8b5c81c
Resolve review feedback
Hinton 09a4f28
Fix link command
Hinton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Versioning & Breaking Changes | ||
|
||
The SDK strives towards maintaining backward compatibility for a reasonable time. This ensures that | ||
dani-garcia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
client applications can safely upgrade to newer versions of the SDK without resolving a large number | ||
of breaking changes. For a more in-depth explanation of what constitutes a breaking change in rust, | ||
see the [SemVer Compatibility section](https://doc.rust-lang.org/cargo/reference/semver.html) in | ||
[the Cargo book](https://doc.rust-lang.org/cargo/index.html). | ||
|
||
There may be certain functionality that is actively being developed and is not yet stable. In these | ||
cases, they should be marked as such and gated behind a `unstable` feature flag. Consuming client | ||
applications should avoid merging changes that depend on these features into `main`. | ||
|
||
To track breaking changes, we use a [changelog file in the `bitwarden` crate][changelog]. This file | ||
should be updated with noteworthy changes for each PR. | ||
|
||
[changelog]: https://github.com/bitwarden/sdk/blob/main/crates/bitwarden/CHANGELOG.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: I know this is an established format but to me
ClientGenerator
sounds weird, like it's something that generates clients. It's the same thing with the other client extensions, e.g.ClientVault
which sounds like there are multiple vaults and this one belongs to theClient
.On the other hand
ClientGeneratorExt
sounds very reasonable, it's aGenerator Extension
for theClient
.I don't think I would've reacted to this if we would've just passed around the
Client
struct and simply appliedExtensions
to it, i.e.Client.password(...)
, but as it is now, we are actually creating secondary "sub-clientswhich themself have a reference to the
Clientinstance.
Client.generator()` actively constructs a new type of "Client"Maybe I'm just nitpicking I don't know, but I think we'll have problems referring to things in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open for alternative name schemas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hinton
Well my suggestion is to flip the name from ClientGenerator to GeneratorClient, not that big change considering how big my previous message was xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Mind creating a jira issue and tackling this mountain of a task :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hinton Done! PM-13166 Rename SDK sub-clients to
<>Client
instead ofClient<>