Skip to content

Commit

Permalink
ADR for integration identification
Browse files Browse the repository at this point in the history
  • Loading branch information
withinfocus committed Oct 23, 2024
1 parent d0036f4 commit 4850b7f
Showing 1 changed file with 72 additions and 0 deletions.
72 changes: 72 additions & 0 deletions docs/architecture/adr/0023-integration-identifiers.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
---
adr: "0023"
status: Proposed
date: 2024-10-22
tags: [server]
---

# 0023 - Identifying Integrated Clients

<AdrTable frontMatter={frontMatter}></AdrTable>

## Context and Problem Statement

Traffic on the Bitwarden platform continues to grow. As that load increases on our systems it
becomes imperative to understand how and when our various clients are connecting to our API and
other server-side components. Not all traffic is currently well-formed and certain key pieces of
information such as accurate device type signatures and user agents as well as client versions are
missing or invalid. To best support client-server interactivity there is a desire to not only inform
deprecated or obsolete integrations that there could be issues, but to protect those server-side
components from integrations that could do outright harm to the platform or client data.

Beyond the immediate observability needs, there is a significant portion of the community that uses
alternative (not developed by Bitwarden) clients to access vault data and perform operations. These
integration methods are perfectly acceptable but are largely unknown, with many not necessarily
being offered as independent applications but custom integrations for proprietary purposes.
Bitwarden would like to register these integrations somehow to better understand platform usage and
utilize common sense constraints to keep the overall platform more resilient and prepare for traffic
shape changes. Furthermore, a number of Bitwarden-developed integrations are largely external such
as our [Splunk][splunk] and [Sentinel][sentinel] apps that should also be registered.

## Considered Options

- **Maintain current integration method** - Make no changes to validation or registration of traffic
and expect self-regulation of integrations.
- **Support only Bitwarden integrations** - Utilize application signature checks and other security
features to only allow Bitwarden-developed clients to connect to server-side components, therefore
constraining traffic to known entities.
- **Validate baseline expectations** - Inspect and eventually enforce several checks on traffic so
that all integrations provide a minimum amount of information on their state so that the platform
can be better monitored.
- **Register integrations along with validation** - Develop a simple registration method for
integrations so that they are enumerated and known to Bitwarden, whether internally or externally
developed. Associate validation with registered integrations for enhanced developer feedback.

## Decision Outcome

Chosen option: **Register integrations along with validation**.

While this is more effort for Bitwarden to develop than just adding validation, combining efforts to
expect more from integrations' request data with also providing a registration identifier is a
simple addition.

### Positive Consequences

- Integrations are registered and known to the platform for sensible traffic identification.
- Bitwarden's operations group receives data to aid in maintainability of the platform, especially
to keep things running well for users while keeping out bad actors.
- Feedback to Bitwarden support teams on version usage is available.
- Bitwarden's support policy of a certain number of major versions can be more actively enforced.

### Negative Consequences

- Integrations will need to make the effort to register with Bitwarden and adjust their requests,
potentially with brief disruptions for them.
- Very small latency may be added for the additional validations.

### Plan

TBD.

[splunk]: https://bitwarden.com/help/splunk-siem/
[sentinel]: https://bitwarden.com/help/microsoft-sentinel-siem/

0 comments on commit 4850b7f

Please sign in to comment.