[deps] Platform: Update Rust crate windows to v0.58.0 #10580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
bitwarden-bot
changed the title
|
Internal tracking:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10580 +/- ##
==========================================
- Coverage 33.48% 33.45% -0.03%
==========================================
Files 2844 2845 +1
Lines 89044 89099 +55
Branches 16987 16992 +5
==========================================
- Hits 29812 29810 -2
- Misses 56887 56943 +56
- Partials 2345 2346 +1 ☔ View full report in Codecov by Sentry. |
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/windows-0.x
branch
2 times, most recently
from
cfaf2e3
to
c1c6a86
Compare
renovate
bot
force-pushed
the
renovate/windows-0.x
branch
from
c1c6a86
to
3e328f1
Compare
renovate
bot
force-pushed
the
renovate/windows-0.x
branch
from
3e328f1
to
7f9c70b
Compare
renovate
bot
force-pushed
the
renovate/windows-0.x
branch
2 times, most recently
from
d549e3f
to
0a6b0e4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
renovate
bot
force-pushed
the
renovate/windows-0.x
branch
2 times, most recently
from
5436564
to
f795173
Compare
renovate
bot
force-pushed
the
renovate/windows-0.x
branch
from
f795173
to
06c107e
Compare
dani-garcia
force-pushed
the
renovate/windows-0.x
branch
from
91575a6
to
50c74c8
Compare
|
Fixed Issues
|
dani-garcia
reviewed
Nov 14, 2024
| @@ -174,7 +176,7 @@ fn focus_security_prompt() -> Result<()> { | |||
| class_name: windows::core::PCSTR, | |||
| ) -> retry::OperationResult<(), ()> { | |||
| let hwnd = unsafe { FindWindowA(class_name, None) }; | |||
| if hwnd.0 != 0 { | |||
| if let Ok(hwnd) = hwnd { | |||
There was a problem hiding this comment.
The windows crate now maps the returning null pointer to an error, so we don't have to manually check that it's not null: https://github.com/microsoft/windows-rs/blob/a8e14c75581bb89fc244ad480f98567be972aea2/crates/libs/windows/src/Windows/Win32/UI/WindowsAndMessaging/mod.rs#L909
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
=0.57.0->=0.58.0Release Notes
microsoft/windows-rs (windows)
v0.58.0Compare Source
This release includes updates to metadata for new or fixed API definitions (#3111, #3136), various improvements and fixes to code generation, compliance with new Rust warnings, additional COM authoring support improvements (#3065), limited non-Windows support (#3135), and more.
It includes major updates to the following crates, mainly due to breaking changes in metadata for API definitions.
riddle0.58.0windows0.58.0windows-bindgen0.58.0windows-core0.58.0windows-implement0.58.0windows-interface0.58.0windows-metadata0.58.0It also includes major updates to the following utility crates.
windows-result0.2.0windows-registry0.2.0The
windows-resultcrate now provides limited non-Windows support, and thewindows-registrycrate offers new lossless queries for binary and wide string values.And it includes minor updates to the
windows-targetscrates, with the addition of several new APIs.windows-targets0.52.6This release also includes the first published version of the
windows-stringscrate, moving the string types from thewindows-corecrate into a dedicated crate as a smaller dependency. It also offers an efficientHSTRINGbuilder (#3133).To clarify, the only crates that continue to support limited non-Windows builds are:
windows-bindgenandwindows-metadatafor code generation on non-Windows platforms.windows-coreandwindows-resultfor COM support on non-Windows platforms.What's Changed
rustfmtfor repo by @kennykerr in https://github.com/microsoft/windows-rs/pull/3084windows-bindgendirectly by @kennykerr in https://github.com/microsoft/windows-rs/pull/3086windows-resultto work on non-Windows platforms by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3082Debugderive macro does not need to be qualified by @kennykerr in https://github.com/microsoft/windows-rs/pull/3097unusedto deal with new warning about "unused" private fields in structs by @kennykerr in https://github.com/microsoft/windows-rs/pull/3103miodependency by @kennykerr in https://github.com/microsoft/windows-rs/pull/3107windowscrate works by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3110cargo run ...by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3113windowsandwindows-sysin unit test mode by @sivadeilra in https://github.com/microsoft/windows-rs/pull/3112windows-stringscrate by @kennykerr in https://github.com/microsoft/windows-rs/pull/3125windows-coreinternals by @kennykerr in https://github.com/microsoft/windows-rs/pull/3129windows-bindgenby @kennykerr in https://github.com/microsoft/windows-rs/pull/3130ErrorandResult<()>to be the same size asHRESULTby @sivadeilra in https://github.com/microsoft/windows-rs/pull/3126windows-corecrate by @kennykerr in https://github.com/microsoft/windows-rs/pull/3131windows_slim_errorsby @kennykerr in https://github.com/microsoft/windows-rs/pull/3132HSTRINGbuilder and registry support by @kennykerr in https://github.com/microsoft/windows-rs/pull/3133SendandSyncforWeak<T>by @kennykerr in https://github.com/microsoft/windows-rs/pull/3138Futureimplementation by @kennykerr in https://github.com/microsoft/windows-rs/pull/3142HSTRINGbuilder provides initialized memory by @kennykerr in https://github.com/microsoft/windows-rs/pull/3141windows-stringscrate Windows-only by @kennykerr in https://github.com/microsoft/windows-rs/pull/3143Full Changelog: microsoft/windows-rs@0.57.0...0.58.0
Configuration
📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.