-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSIP73: Match force-settlement orders with margin calls and limit orders #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my "pedantic" mode was left on. The document is readable without any of the grammar changes I propose. Technically, this BSIP provides a clear picture of what is desired. Thanks!
I would happily mark this "approved" as-is, but would like to give others some time to review it.
Thanks. |
Thank you @pmconrad. The "Summary for Shareholders" section is still "TBD", I hope someone can help. |
Suggested summary: When force-settling a SmartCoin, the user currently has to wait for the settlement delay before his tokens are exchanged for the collateral asset. This BSIP introduces a new flag that allows settlement requests to be matched with market orders during the waiting period, potentially resulting in faster settlement and a better price. |
@pmconrad thanks. Please review again. |
Should this be incorporated in the summary, or do we rather not burden the voters with this technical aspect? |
|
PR for #181.