Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES plugins default values #2012

Merged
merged 1 commit into from
Oct 12, 2019
Merged

ES plugins default values #2012

merged 1 commit into from
Oct 12, 2019

Conversation

oxarbitrage
Copy link
Member

elasticsearch plugin:

  • _elasticsearch_operation_object is the most used option to have all operation fields indexed. Is what most operators are after this days. Changed to true by default.
  • _elasticsearch_operation_string is the alternative to save the full operation as 1 field of type string. This is needed for only_query or all modes. Is not the most frequent use case at the moment, changed the default to false.

es_objects plugin:

  • _es_objects_limit_orders is currently not used in the bitshares-rest-api. It eats too much space and also the updates to them are very frequent causing overhead. Turned this option to false
    by default.

@abitmore abitmore added this to the 4.1.0 - Feature Release milestone Sep 24, 2019
@pmconrad
Copy link
Contributor

Makes sense.

@abitmore
Copy link
Member

abitmore commented Oct 7, 2019

I guess this needs a full replay, but not only replay with *_after_block. Maybe need docs somewhere, e.g. release notes?

@abitmore abitmore added the 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added label Oct 7, 2019
@oxarbitrage
Copy link
Member Author

I am updating the elasticsearch wiki and i think it will be better if we have the doc with this defaults.

Full replay might be needed in some cases. Release notes should do it. Opened #2024 for this.

@oxarbitrage oxarbitrage merged commit 41d1cca into develop Oct 12, 2019
@abitmore abitmore deleted the es_default_values branch October 12, 2019 16:13
@oxarbitrage
Copy link
Member Author

Updated/simplified the elasticsearch plugins wiki https://github.com/bitshares/bitshares-core/wiki/ElasticSearch-Plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants