Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

zhouxiaobao-2010
Copy link
Contributor

No description provided.

@zhouxiaobao-2010 zhouxiaobao-2010 self-assigned this Nov 7, 2019
@sschiessl-bcp
Copy link

This is one point where the conflict arises.

The established process is:

  1. open an issue, and discuss
  2. once considered ripe enough, editors will assign a number
  3. open a PR, and discuss
  4. editors will review and approve, then merge

You repeat 1.-4. until the BAIP has reached the status "Accepted". Then, and only then, the BAIP is put up for voting on the blockchain. This is how our process ensures quality of BAIPs.

Please reconsider to follow this procedure for BAIP-02. In particular, this means: Open a new PR, address the review from the previews PR (even if it is only to add clarification in the text), and add the status change from "Draft" to "Accepted". This is especially crucial for controversial decisions, and BSIP-76 shows how much of a conflict it creates.

The review is not that extensive, and I've heard already that many people agree with BAIP-02. We need to stick to proper process to ensure we are all pulling the same string, ensure quality in our governance procedure and reduce points of conflict.

I do not say that to annoy you, or to cause you unnecessary work. It will give your BAIP a much better standing (no one can call it invalid), and improve credibility of the authors.

@bangzi1001
Copy link
Contributor

You repeat 1.-4. until the BAIP has reached the status "Accepted". Then, and only then, the BAIP is put up for voting on the blockchain. This is how our process ensures quality of BAIPs.

According to BAIP Purpose and Guidelines:
"Once a BAIP has been published, the reference implementation must be completed. When the reference implementation is complete and accepted by the BTS holders via approval voting, the status will be changed to "Accepted". A BAIP can also be "Rejected" by BTS holders."

@grctest
Copy link

grctest commented Nov 8, 2019

reference implementation must be completed

No reference implementation was demonstrated by BAIP2, instead the responsibility to create a reference implementation was delegated to price feed publishers.

@abitmore
Copy link
Member

abitmore commented Nov 8, 2019

@sschiessl-bcp I think it's better to finalize BSIP-01 first. See #11 (comment).

BAIP7:Proposal on bitASSETS dividend and BTS destruction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants