Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate config files to pyproject.toml #1373

Merged

Conversation

SauravMaheshkar
Copy link
Contributor

@SauravMaheshkar SauravMaheshkar commented Sep 26, 2024

This PR aims to drop the configuration files in favour of pyproject.toml in order to have a more minimal project structure.

Request for Review: @matthewdouglas

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated
Comment on lines 25 to 87
"slow: mark test as slow",
"benchmark: mark test as a benchmark",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be in alphabetical order, as they were in the INI file.

@matthewdouglas
Copy link
Member

There's an older PR (#1078) that I had started a while ago for the same thing. I'm OK superseding that one with this PR but with some more changes to match the intent of #1078.

The biggest of those changes would be to move more from setup.py to pyproject.toml as was done in #1078.

@SauravMaheshkar
Copy link
Contributor Author

There's an older PR (#1078) that I had started a while ago for the same thing. I'm OK superseding that one with this PR but with some more changes to match the intent of #1078.

The biggest of those changes would be to move more from setup.py to pyproject.toml as was done in #1078.

@matthewdouglas I've ported over some of your work from #1078 to this PR. Before I port over changes to the Github Actions changes as well, let's resolve the older comments.

@SauravMaheshkar
Copy link
Contributor Author

Gentle ping @matthewdouglas

pyproject.toml Outdated Show resolved Hide resolved
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@matthewdouglas matthewdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on main and fixed a couple conflicts. Looks good otherwise. Thanks!

@matthewdouglas matthewdouglas merged commit 5b01589 into bitsandbytes-foundation:main Dec 17, 2024
31 checks passed
@SauravMaheshkar SauravMaheshkar deleted the saurav/configs branch December 17, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants