-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deepcopy and copy for Param4bit #1060
Merged
Titus-von-Koeller
merged 15 commits into
bitsandbytes-foundation:main
from
SunMarc:deepcopy-param4bit
Feb 21, 2024
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
af7b492
fix deepcopy and copy
SunMarc 6c8871b
add tests
SunMarc 1482d93
remove line
SunMarc ae0fcdf
ruff fix
SunMarc 587e7c2
ruff
SunMarc b4f9384
Update tests/test_linear4bit.py
SunMarc f62b0a2
Merge branch 'main' into deepcopy-param4bit
Titus-von-Koeller fe8eb71
Merge branch 'main' into deepcopy-param4bit
Titus-von-Koeller 9e32d68
add missing state
SunMarc 34735ba
ruff format
Titus-von-Koeller eead51f
ignore formatting commit for git blame
Titus-von-Koeller c064373
Params4bit should be initialized as frozen by default
Titus-von-Koeller 00b6f31
add test for serialization round-tripping
Titus-von-Koeller ad87fc4
add comparison capability for QuantSate
Titus-von-Koeller b3a9bd5
add back accidentally remove line
Titus-von-Koeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is having to do this dance common in Torch world? 🤔
I'm a little worried that someone adding a new field in
__init__
will inevitably miss adding them here...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think but I wasn't able to find a better solution. I based my solution over this specific code from torch.
Yeah, that's true :/ . I tried modify
__setstate__
so that we udpatestate.__dict__
usingself.__dict__
but some attributes were not copied properly.