Fix deploy with Hubspot API v3 #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hubspot’s v2 api was not returning all pages, even though we were not hitting the limit. This was causing some pages to be re-created even though they already existed. Hubspot was appending an integer for a while then began appending a timestamp to avoid overwriting the existing page. Looking at the timestamps of the published pages, this has been a problem since December 2020, and 80 copies of each page have been mistakenly published. I tested the code on the `learn-docker` pages and it successfully updated the files. Before publishing the entire site, I’m going to let somebody else take a look and run the code. There was some previous work done to say how many pages need to be deleted. I updated the code to log the slug of each duplicate/orphaned page, which shows the pages that end in timestamps (Hubspot duplicate prevention). We will need to make another PR to delete the orphaned pages. Improves debuggability of some code, as well.
|
This looks good to me. Can you run it and merge tomorrow? I will be able to test it after. I don't see a script to clean up? Is that in another PR? Thanks! |
Modifies the publish script to… - log the page slug in the “Update Success” message, since slugs give more context than page titles. - log which files were deleted from Bitovi.com - comment out the delete process until manually verified by another developer. One line will need to be uncommented after verifying that the list of files to be deleted is correct.
|
@justinbmeyer, I added a few lines to enable deletion of old pages. The logging was been updated to list the slugs that were published and the slugs that the script "think" need to be removed. I've left it commented out until the pages to be removed are verified. Here's the line to uncomment once the pages are verified. Also, I ran the publish script and it completed successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hubspot’s v2 api was not returning all pages when we requested them. We were not hitting the limit. It appears to be a bug that they fixed in v3 of their API. The bug was causing some pages to be re-created even though they already existed. Hubspot was appending an integer for a while then began appending a timestamp to avoid overwriting the existing page. Looking at the timestamps of the published pages, this has been a problem since December 2020, and 80 copies of each erroring page have been mistakenly published.
I tested the code on the
learn-dockerpages and it successfully updated the files. Before publishing the entire site, I’m going to let somebody else take a look and run the code.There was some previous work done to say how many pages need to be deleted. I updated the code to log the slug of each duplicate/orphaned page, which shows the pages that end in timestamps (Hubspot duplicate prevention). We will need to make another PR to delete the orphaned pages.
I haven't run the script to fix the other broken files, yet. We need to do that after review/merge.
Improves debuggability of some code, as well.