Migrate to latest Conviva types #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karpov-kir
commented
May 14, 2024
karpov-kir
commented
May 14, 2024
karpov-kir
commented
May 14, 2024
karpov-kir
commented
May 14, 2024
src/ts/ContentMetadataBuilder.ts
Outdated
| }; | ||
| const customContentInfo: CustomContentMetadata = { | ||
| [Conviva.Constants.FRAMEWORK_NAME]: this.contentMetadata.framework, | ||
| [Conviva.Constants.FRAMEWORK_VERSION]: this.contentMetadata.frameworkVersion, |
There was a problem hiding this comment.
These two are not present in ReservedContentMetadata props, so they should be custom data.
There was a problem hiding this comment.
I think it would make sense to deprecate/remove those two options in that case. Customers can set any custom data anyway. What do you think?
karpov-kir
commented
May 14, 2024
karpov-kir
commented
May 14, 2024
dweinber
reviewed
May 14, 2024
dweinber
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://bitmovin.atlassian.net/browse/TA-2596
./@types/conviva/ConvivaExtension.d.tswith types that are missing in the core package typests-loaderand TypeScript so that the project compiles fine (I've added some comments in the PR with explanations)This PR is required to finalize #104.