Clean up

bitmovin · May 14, 2024 · c4a9132 · c4a9132
1 parent ee0566b
commit c4a9132
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/@types/conviva/ConvivaExtension.d.ts b/@types/conviva/ConvivaExtension.d.ts
@@ -1,5 +1,6 @@
 /**
- * Add missing types from `conviva-core-sdk` package.
+ * The following properties exist on the `window.Conviva` object but they are missing
+ * in types of `conviva-core-sdk` package for some reason, so let's add them manually.
  */
 
 declare module Conviva {

diff --git a/spec/tests/PlayerEvents.spec.ts b/spec/tests/PlayerEvents.spec.ts
@@ -240,7 +240,6 @@ describe('player event tests', () => {
       expect(convivaVideoAnalytics.reportAdBreakStarted).toHaveBeenCalledWith(
         Conviva.Constants.AdType.CLIENT_SIDE,
         Conviva.Constants.AdPlayer.SEPARATE,
-        Conviva.Constants.AdPosition.PREROLL,
       );
     });
 
@@ -251,7 +250,6 @@ describe('player event tests', () => {
       expect(convivaVideoAnalytics.reportAdBreakStarted).toHaveBeenCalledWith(
         Conviva.Constants.AdType.CLIENT_SIDE,
         Conviva.Constants.AdPlayer.SEPARATE,
-        Conviva.Constants.AdPosition.MIDROLL,
       );
     });
 

diff --git a/src/ts/ConvivaAnalytics.ts b/src/ts/ConvivaAnalytics.ts
@@ -354,7 +354,6 @@ export class ConvivaAnalytics {
     this.convivaVideoAnalytics.reportAdBreakStarted(
       Conviva.Constants.AdType.CLIENT_SIDE,
       Conviva.Constants.AdPlayer.SEPARATE,
-      // Conviva.Constants.AdPosition.PREROLL,
     );
     this.debugLog('Tracking paused.');
   }
@@ -693,14 +692,9 @@ export class ConvivaAnalytics {
       return;
     }
 
-    this.debugLog('[ ConvivaAnalytics ] report ad break started', {
-      event,
-      adPosition,
-    });
     this.convivaVideoAnalytics.reportAdBreakStarted(
       Conviva.Constants.AdType.CLIENT_SIDE,
       Conviva.Constants.AdPlayer.SEPARATE,
-      // adPosition,
     );
   };
 
@@ -713,9 +707,6 @@ export class ConvivaAnalytics {
       return;
     }
 
-    this.debugLog('[ ConvivaAnalytics ] report ad break ended', {
-      event,
-    });
     this.convivaVideoAnalytics.reportAdBreakEnded();
     this.convivaVideoAnalytics.reportPlaybackMetric(
       Conviva.Constants.Playback.PLAYER_STATE,